Conversation
toloudis
reviewed
May 20, 2021
| @@ -0,0 +1,68 @@ | |||
| name: Auto deploy staging AWS | |||
| env: | |||
| NODE_VERSION: '12.x' | |||
Contributor
There was a problem hiding this comment.
I keep forgetting, why are we stuck on node 12? gh-actions workers have node 14 something auto installed
Contributor
Author
There was a problem hiding this comment.
It's the version we were using when we started the cfe repo I think, we can update it. For a while we had both 12 and 14. I think it's pretty standard to include 2 so you can feel comfortable going up to the next version.
Contributor
|
Probably unrelated, but what's daily-new-viewer.yml in the github workflows folder? Is that in use? If not should it go away? |
schoinh
approved these changes
May 20, 2021
Contributor
schoinh
left a comment
schoinh
left a comment
There was a problem hiding this comment.
Looks good to me... This is gonna be great! Thanks!
ghost
approved these changes
May 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Move deployment from Jenkins to github actions
Link to story or ticket
Solution
I copied over jobs from CFE, with one change: CFE just copies the staging build into the production bucket, but since we want a different backend for staging and production, the production script does a fresh build
Type of change
Please delete options that are not relevant.
Thanks for contributing!