Skip to content

Fix/in modified state still click buttons#151

Merged
meganrm merged 3 commits intomasterfrom
fix/in-modified-state-still-click-buttons
Jun 29, 2021
Merged

Fix/in modified state still click buttons#151
meganrm merged 3 commits intomasterfrom
fix/in-modified-state-still-click-buttons

Conversation

@meganrm
Copy link
Copy Markdown
Contributor

@meganrm meganrm commented Jun 25, 2021

Problem

If you held down a modifier key and then clicked another camera control key, like the up button, it would break the state indicator (ie you'd still be in pan state, but the toggle button would show rotate state)
resolves #150

Solution

Check to see if a modifier is being held in key up listener
with @pairperson1

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to Verify:

  1. npm start
  2. hold down shift
  3. click down or up button
  4. let go of shift
  5. rotate toggle button should switch only once you release the shift button

@meganrm meganrm force-pushed the fix/in-modified-state-still-click-buttons branch from b4eeb9f to ebd00d0 Compare June 25, 2021 21:39
@meganrm meganrm requested review from a user, blairlyons, schoinh and toloudis June 25, 2021 21:40
@meganrm meganrm merged commit 07cc67f into master Jun 29, 2021
@meganrm meganrm deleted the fix/in-modified-state-still-click-buttons branch June 29, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If you're in a modified state, ie holding command, other buttons, like up/down should still work

3 participants