Fix/in modified state still click buttons#151
Merged
Conversation
b4eeb9f to
ebd00d0
Compare
blairlyons
approved these changes
Jun 29, 2021
toloudis
approved these changes
Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If you held down a modifier key and then clicked another camera control key, like the up button, it would break the state indicator (ie you'd still be in pan state, but the toggle button would show rotate state)
resolves #150
Solution
Check to see if a modifier is being held in key up listener
with @pairperson1
Type of change
Please delete options that are not relevant.
Steps to Verify: