Conversation
meganrm
requested review from
blairlyons,
schoinh and
toloudis
and removed request for
a team
| biologists by removing major challenges to sharing, | ||
| accessing, and comparing simulation results. | ||
| </p> | ||
| <div className={styles.textContent}> |
There was a problem hiding this comment.
this looks like a lot of changes but all i did was add a div around the text content instead of styling with .panel * which I initially thought might be causing the problem, but left because it seems safer
|
|
||
| .markdown { | ||
| column-count: 2; | ||
| height: 540px; |
There was a problem hiding this comment.
this is the change that fixes the problem (see screen shots for before and after of the acknowledgments)
There was a problem hiding this comment.
That's what I would have done (I had made this issue for this bug but looks like it got buried - #329)
There was a problem hiding this comment.
Oh man! I totally missed this, I'll be better about searching in the issues in the future. Thanks for reviewing!
jest coverage report 🧪Total coverage
|
|
|
||
| .markdown { | ||
| column-count: 2; | ||
| height: 540px; |
There was a problem hiding this comment.
That's what I would have done (I had made this issue for this bug but looks like it got buried - #329)
3 participants
Problem
On chrome the landing page had horizontal scroll
Solution
I first narrowed it down to the
max-widthsetting on the text content, but it was just an arbitrary cutoff: If i set it to over 1040px, there was no scroll.So I finally figured out it was the markdown content, we had both column number and height set, which I guess caused an invisible overflow even though the text fit.
Type of change
Please delete options that are not relevant.
Change summary:
Steps to Verify:
Screenshots (optional):
Before:
NOTICE the text is longer in column 2
After: