You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We can change the name of the param to whatever, I know there was some discussion of having demo in there to make sure it's clear this isn't a long term solution.
Pull request recommendations:
Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
Link to any relevant issue in the PR description. Ex: Resolves [gh-##], adds tiff file format support
Provide description and context of changes.
Provide relevant tests for your feature or bug fix.
Provide or update documentation for any feature added by your pull request.
right now it's still agentviz.allencell.org/?trajFileName= but we should change it to simularium.allencell.org
If that's the url without any subdirectory then we really should use a param name that seems temporary or unique for this early version.
I was hoping for something like simularium.allencell.org/dragndropdemo/?trajFileName=
or simularium.allencell.org/playback/?trajFileName=
which qualifies it better.
I haven't looked at our spec lately so I don't know if any of the larger full blown simularium website has been sketched out structurally. I still feel like this first thing is different enough from the final thing that it should live in its own corner.
I like the suggestion for simularium.allencell.org/dragndropdemo/?trajFileName=
or simularium.allencell.org/playback/?trajFileName=
but I also think that what Megan added here works well enough for a quick MVP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very simple implementation for accomplishing this: https://aicsjira.corp.alleninstitute.org/browse/AGENTVIZ-868
We can change the name of the param to whatever, I know there was some discussion of having demo in there to make sure it's clear this isn't a long term solution.
Pull request recommendations:
Thanks for contributing!