Skip to content

Feature/url open file#4

Merged
meganrm merged 2 commits intomasterfrom
feature/urlOpenFile
Jul 30, 2020
Merged

Feature/url open file#4
meganrm merged 2 commits intomasterfrom
feature/urlOpenFile

Conversation

@meganrm
Copy link
Copy Markdown
Contributor

@meganrm meganrm commented Jul 30, 2020

This is a very simple implementation for accomplishing this: https://aicsjira.corp.alleninstitute.org/browse/AGENTVIZ-868

We can change the name of the param to whatever, I know there was some discussion of having demo in there to make sure it's clear this isn't a long term solution.

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [gh-##], adds tiff file format support
  • Provide description and context of changes.
  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

@meganrm meganrm requested review from a user, blairlyons and toloudis July 30, 2020 00:37
@toloudis
Copy link
Copy Markdown
Contributor

What will the first part of the url look like?

@meganrm
Copy link
Copy Markdown
Contributor Author

meganrm commented Jul 30, 2020

right now it's still agentviz.allencell.org/?trajFileName= but we should change it to simularium.allencell.org

@toloudis
Copy link
Copy Markdown
Contributor

right now it's still agentviz.allencell.org/?trajFileName= but we should change it to simularium.allencell.org

If that's the url without any subdirectory then we really should use a param name that seems temporary or unique for this early version.
I was hoping for something like
simularium.allencell.org/dragndropdemo/?trajFileName=
or
simularium.allencell.org/playback/?trajFileName=
which qualifies it better.

I haven't looked at our spec lately so I don't know if any of the larger full blown simularium website has been sketched out structurally. I still feel like this first thing is different enough from the final thing that it should live in its own corner.

@ghost
Copy link
Copy Markdown

ghost commented Jul 30, 2020

I like the suggestion for
simularium.allencell.org/dragndropdemo/?trajFileName=
or
simularium.allencell.org/playback/?trajFileName=
but I also think that what Megan added here works well enough for a quick MVP

@meganrm meganrm merged commit 59d0599 into master Jul 30, 2020
@meganrm meganrm deleted the feature/urlOpenFile branch August 28, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants