Skip to content

Fix/ui panel#45

Merged
meganrm merged 2 commits intomasterfrom
fix/ui-panel
Oct 16, 2020
Merged

Fix/ui panel#45
meganrm merged 2 commits intomasterfrom
fix/ui-panel

Conversation

@meganrm
Copy link
Copy Markdown
Contributor

@meganrm meganrm commented Oct 15, 2020

Fixes 2 bugs I introduced:

  1. I batched actions in the logics, but forgot to wrap them in dispatch so they weren't actually be dispatched.

  2. I was also calling setViewerState with the wrong type of object, and it concerns me that it didn't cause a typeScript error. If anyone knows why, would be helpful

This fixes the current problem of the loading indicator not showing up and the UI panel not rendering

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [gh-##], adds tiff file format support
  • Provide description and context of changes.
  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

@meganrm meganrm requested review from a user, blairlyons, schoinh and toloudis October 15, 2020 23:52
@schoinh
Copy link
Copy Markdown
Contributor

schoinh commented Oct 16, 2020

Regarding #2....... it seems that TS doesn't check for type for any of the actions from dispatchToPropsMap in this file. Or at least, I tried putting in a single number as an argument for receiveMetadata in line 188 and it didn't give any type errors, either. That's disturbing.....

@meganrm meganrm merged commit e08b32d into master Oct 16, 2020
@meganrm meganrm deleted the fix/ui-panel branch October 16, 2020 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants