Conversation
ghost
approved these changes
Oct 20, 2020
| background-color: var(--dark-theme-btn-disabled-bg); | ||
| color: var(--dark-theme-btn-disabled-color); | ||
|
|
||
| background-color: var(--dark-theme-btn-disabled-bg)!important; |
There was a problem hiding this comment.
Is there a reason to use !important here over disabling pointer events?
not a major issue here, but afaik !important is often avoided since it can be difficult to debug in conflicting cases
Contributor
Author
There was a problem hiding this comment.
antd had it own [disabled]:hover color state. I could do that instead but all of this is confined to just the buttons in this folder
schoinh
reviewed
Oct 20, 2020
| simulariumController.playFromTime(time + timeStep); | ||
| const { time, timeStep, simulariumController, totalTime } = this.props; | ||
| let newTime = time + timeStep; | ||
| if (newTime === totalTime) { |
Contributor
There was a problem hiding this comment.
Is there any chance newTime could be greater than totalTime?
Contributor
Author
There was a problem hiding this comment.
I don't think it ever should be, but I did use that as a check in other places in case there is a rounding issue somewhere or something, I cad add that here
schoinh
approved these changes
Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: when the trajectory got to the end of the file, it stopped playing, but the play button was still in the "playing" state.
Fix:
Other fixes:
Pull request recommendations:
Thanks for contributing!