Skip to content

feature/update simularium-viewer to v2.4.9#72

Merged
schoinh merged 3 commits intomasterfrom
feature/update-viewer-to-2.4.8
Nov 25, 2020
Merged

feature/update simularium-viewer to v2.4.9#72
schoinh merged 3 commits intomasterfrom
feature/update-viewer-to-2.4.8

Conversation

@schoinh
Copy link
Copy Markdown
Contributor

@schoinh schoinh commented Nov 25, 2020

Getting staging up-to-date before Thanksgiving break.

Main updates:

  • showing a pointing hand cursor when the user hovers over an agent in the simulation
  • agent color updates
  • increased depth cueing

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [gh-##], adds tiff file format support
  • Provide description and context of changes.
  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

@schoinh schoinh requested review from a user, blairlyons and meganrm November 25, 2020 20:13
Copy link
Copy Markdown
Contributor

@meganrm meganrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have two more outstanding visual changes to the viewer that we might want to try to get in by EOD: simularium/simularium-viewer#71

@blairlyons
Copy link
Copy Markdown
Contributor

We have two more outstanding visual changes to the viewer that we might want to try to get in by EOD: allen-cell-animated/simularium-viewer#71

I just approved Megan's PR and merged mine

@meganrm
Copy link
Copy Markdown
Contributor

meganrm commented Nov 25, 2020

I just published 2.4.9

@schoinh schoinh changed the title feature/update simularium-viewer to v2.4.8 feature/update simularium-viewer to v2.4.9 Nov 25, 2020
Copy link
Copy Markdown
Contributor

@meganrm meganrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approval for the colors

@schoinh schoinh merged commit 87c2053 into master Nov 25, 2020
@schoinh schoinh deleted the feature/update-viewer-to-2.4.8 branch November 25, 2020 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants