Feature/add-blank-library-card-to-landing-page#73
Merged
Conversation
blairlyons
approved these changes
Nov 30, 2020
toloudis
reviewed
Nov 30, 2020
| </Link> | ||
| <p> | ||
| Load your own data into the viewer. Learn how to convert | ||
| your data{" "} |
Contributor
There was a problem hiding this comment.
is the bracketed quotes just a way of forcing a whitespace character?
Contributor
Author
There was a problem hiding this comment.
Yes. Is there a better way to do this? (this also gets auto-added by our formatter)
Contributor
There was a problem hiding this comment.
I'm not aware of a better way and the formatter probably knows what it's doing there because it has to add a line break.
toloudis
approved these changes
Nov 30, 2020
meganrm
approved these changes
Nov 30, 2020
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 for issue change landing page copy
Previously Done (Feature/update landing page copy):
Done in this PR:
Not Done Yet:
Pull request recommendations:
Thanks for contributing!