Skip to content

Feature/add-blank-library-card-to-landing-page#73

Merged
schoinh merged 14 commits intomasterfrom
feature/landing-page-additions
Nov 30, 2020
Merged

Feature/add-blank-library-card-to-landing-page#73
schoinh merged 14 commits intomasterfrom
feature/landing-page-additions

Conversation

@schoinh
Copy link
Copy Markdown
Contributor

@schoinh schoinh commented Nov 25, 2020

Part 2 for issue change landing page copy

Previously Done (Feature/update landing page copy):

  • Update all the text per Google Doc
  • Make font smaller and make paragraph width narrower for "Simularium future development" text block

Done in this PR:

  • Create "Load your data" library card in landing page
  • Modify the contents of the left panel of an empty viewer page to make sense with the new library card that leads there
  • Revert font size and paragraph width of "Simularium future development" to original formatting

Not Done Yet:

  • Add new graphics (video banner, flowchart for "Simularium future development") -- will be added when they are finished

image
image
image

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [gh-##], adds tiff file format support
  • Provide description and context of changes.
  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

@schoinh schoinh requested review from a user, blairlyons, meganrm and toloudis November 25, 2020 23:34
@schoinh schoinh changed the title Update left side panel copy except for "Load an example instead" link URL Feature/add-blank-library-card-to-landing-page Nov 25, 2020
</Link>
<p>
Load your own data into the viewer. Learn how to convert
your data{" "}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the bracketed quotes just a way of forcing a whitespace character?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Is there a better way to do this? (this also gets auto-added by our formatter)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not aware of a better way and the formatter probably knows what it's doing there because it has to add a line break.

@schoinh schoinh merged commit 59642a0 into master Nov 30, 2020
@schoinh schoinh deleted the feature/landing-page-additions branch November 30, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants