fix/time unit not updating in total time#80
Merged
Conversation
toloudis
reviewed
Dec 8, 2020
| https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/log/#Examples | ||
| */ | ||
| unitIndex = Math.ceil(Math.log(1 / lastFrameTime) / Math.log(1000)); | ||
| let unitIndex = Math.ceil(Math.log(1 / lastFrameTime) / Math.log(1000)); |
Contributor
There was a problem hiding this comment.
I suggest renaming this so it doesn't conflict at all with unitIndex from line 40.
Contributor
Author
There was a problem hiding this comment.
Changed it to index, hopefully it's not too vague..........
toloudis
approved these changes
Dec 8, 2020
meganrm
approved these changes
Dec 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was testing with a trajectory in nanosecond-scale I noticed the unit in the total time wasn't updating -- it's because I was using a regular variable
unitIndexinstead of creating a local state for it. React 101. Let me know if you want test data and I'll send it to you.Pull request recommendations:
Thanks for contributing!