Merged
Conversation
toloudis
approved these changes
Dec 16, 2020
Contributor
toloudis
left a comment
There was a problem hiding this comment.
Assuming it's working properly, the code itself looks fine to me.
Contributor
Author
|
Thao just temporarily enabled the button, and that turned the button all green and weirdly styled. So I just added some more CSS to override that so that it'll look like the screenshot above. Oh and I was able to confirm that the button works. (She just turned it back off for localhost and staging.) |
blairlyons
approved these changes
Dec 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: Add Cookies Settings link to footer
When I click on the button on localhost nothing happens, but according to @thao-do this is expected behavior on local.
Pull request recommendations:
Thanks for contributing!