Skip to content

Feature/add Cookie Settings button#95

Merged
schoinh merged 2 commits intomasterfrom
feature/cookies-settings-link
Dec 16, 2020
Merged

Feature/add Cookie Settings button#95
schoinh merged 2 commits intomasterfrom
feature/cookies-settings-link

Conversation

@schoinh
Copy link
Copy Markdown
Contributor

@schoinh schoinh commented Dec 15, 2020

Resolves: Add Cookies Settings link to footer

When I click on the button on localhost nothing happens, but according to @thao-do this is expected behavior on local.

image

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [gh-##], adds tiff file format support
  • Provide description and context of changes, including any helpful screenshots.
  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

@schoinh schoinh requested review from a user, blairlyons, meganrm, thao-do and toloudis December 15, 2020 20:47
Copy link
Copy Markdown
Contributor

@toloudis toloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it's working properly, the code itself looks fine to me.

@schoinh
Copy link
Copy Markdown
Contributor Author

schoinh commented Dec 16, 2020

Thao just temporarily enabled the button, and that turned the button all green and weirdly styled. So I just added some more CSS to override that so that it'll look like the screenshot above. Oh and I was able to confirm that the button works. (She just turned it back off for localhost and staging.)

@schoinh schoinh merged commit f7f34c8 into master Dec 16, 2020
@schoinh schoinh deleted the feature/cookies-settings-link branch December 16, 2020 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants