Feature/add more UI templates #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/add-more-ui-templates
ascibisz
requested review from
blairlyons,
frasercl,
meganrm and
toloudis
and removed request for
a team
meganrm
approved these changes
Dec 6, 2022
blairlyons
reviewed
Dec 12, 2022
ui-templates/medyan_data.json
Outdated
| }, | ||
| "agentsWithEndpoints": { | ||
| "name": "Agents with endpoints", | ||
| "data_type": "array", |
There was a problem hiding this comment.
instead of a new "array" type, can we use a "collection" for this?
| * `springsalad_data` - information for populating a `SpringsaladData` to visualize a trajectory from SpringSaLaD | ||
| * `cellpack_data` - information for populating a `CellpackData` to visualize a trajectory from Cellpack | ||
|
|
||
| ### Base types |
There was a problem hiding this comment.
Add a description of the new "boolean" type here
blairlyons
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Add templates for Cellpack, Cytosim, Springsalad, and Medyan
Link to story or ticket
Solution
Added the new templates, creating a couple new base types and a new custom type along the way.
Tested that it'd work with the example UI by replacing the smoldyn file with these new files. We will need to make some changes to the UI to support these changes, including adding support for booleans and arrays, as well as creating buttons for these new forms, but that's out of scope for this ticket, and we can deal with that after we finish autoconversion for smoldyn.
Type of change