Skip to content

[util][gear] Generalize find stat implementations. Update Darkmoon Blood implementation for bug fix.#11496

Merged
renanthera merged 2 commits into
simulationcraft:midnightfrom
renanthera:12.0/67823-generalize-stat-lookup
Jun 2, 2026
Merged

[util][gear] Generalize find stat implementations. Update Darkmoon Blood implementation for bug fix.#11496
renanthera merged 2 commits into
simulationcraft:midnightfrom
renanthera:12.0/67823-generalize-stat-lookup

Conversation

@renanthera
Copy link
Copy Markdown
Member

  • [util] Generalize implementation for highest and lowest stat[s]. Rewrite each in terms of generalization.
  • [gear] Update Darkmoon Blood implementation for bug fix.

@renanthera
Copy link
Copy Markdown
Member Author

renanthera commented Jun 2, 2026

Identical for 1 iteration of deterministic=1 on all specs.

diff --git a/tmp/out.txt b/tmp/out2.txt
index fb16e20b68..ed3c738a2d 100644
--- a/tmp/out.txt
+++ b/tmp/out2.txt
@@ -9854,13 +9854,13 @@ Baseline Performance:
   MaxT0Event    = 31
   TargetHealth  = 18221555
   SimSeconds    = 19800.000
-  CpuSeconds    = 16.969203153
-  WallSeconds   = 17.105088507
-  InitSeconds   = 9.409960407
+  CpuSeconds    = 16.978736952
+  WallSeconds   = 17.119080243
+  InitSeconds   = 9.459821119
   MergeSeconds  = 0
-  AnalyzeSeconds= 0.138747113
+  AnalyzeSeconds= 0.136551855
   SpeedUp       = 18
-  EndTime       = 2026-06-02 11:49:34-0600
+  EndTime       = 2026-06-02 11:50:54-0600

@renanthera renanthera merged commit 204b88d into simulationcraft:midnight Jun 2, 2026
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant