[Mage] Frost mage 12.1 set bonus#11524
Merged
vituscze merged 3 commits intoJun 30, 2026
Merged
Conversation
vituscze
requested changes
Jun 30, 2026
| action_t* duality_pyroblast = nullptr; | ||
| int freezing_consume; | ||
| shatter_source_t* shatter_source; | ||
| real_ppm_t* rppm_set_bonus = nullptr; |
Contributor
There was a problem hiding this comment.
This should go into mage_t and be initialized in init_rng, like all the other RNGs
| debuff->refresh(); | ||
| } | ||
|
|
||
| if ( consume_stacks > 0 && sets->has_set_bonus( MAGE_FROST, MID2, B2 ) ) |
Contributor
There was a problem hiding this comment.
Was this tested? Using consume_stacks would mean it doesn't interact with FoF at all. Worth a comment if that is the case.
Contributor
Author
There was a problem hiding this comment.
It works with FoF. Was meant to use shatter_stacks instead of consume_stacks
| procs.icicle_from_set_bonus->occur(); | ||
| // Icicles generated this way cannot grant the Glacial Spike buff on their own (bug?), | ||
| // the player still has to wait for the cyclic icicles proc to gain the buff | ||
| trigger_icicle( 1, false ); |
Contributor
There was a problem hiding this comment.
Probably worth controlling this behavior with player_t::bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.