[Devourer] Model Voidfall building procs as a pseudo-random distribution#11538
Merged
ToppleTheNun merged 2 commits intoJun 28, 2026
Merged
Conversation
The builder proc is a PRD in game, not a flat roll: the per-cast chance starts near 16% after a proc and rises with each miss, averaging the nominal 35% and guaranteed by the 7th cast. Verified against ~24k builder casts from logs. Use accumulated_rng with prd::find_constant, and check the spending buff before the roll so the accumulator only advances on real builder attempts. Mean proc rate and DPS are unchanged; the cadence is less streaky.
ToppleTheNun
requested changes
Jun 27, 2026
| struct accumulated_rngs_t | ||
| { | ||
| // Annihilator | ||
| accumulated_rng_t* voidfall = nullptr; |
Contributor
There was a problem hiding this comment.
don't need the = nullptr here
ToppleTheNun
merged commit 16b061b
into
simulationcraft:midnight
78 of 89 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Voidfall's building proc is currently a flat 35% roll. In game it's a pseudo-random distribution: the per-cast chance starts near 16% after a proc and climbs with each miss, averaging 35% and guaranteed by the 7th cast. This was checked against ~24k builder casts from logs (a controlled dummy plus ranked raids), where the per-attempt rate matches
C*NwithC = prd::find_constant(0.35).voidfall_building_trigger_twithaccumulated_rng, the existing PRD primitive (same pattern as DK/mage/hunter), withCfromprd::find_constanton the talent chance.voidfall_spendingbefore the roll so the accumulator only advances on real builder attempts. The counter resets on a builder proc and does not advance during spending; guaranteed sources (Meteoric Rise, Mass Acceleration) trigger the buff directly and stay off the PRD.DPS-neutral, since
find_constantpreserves the mean. Only the proc cadence is smoothed.This closes: #11154