Skip to content

Conversation

@kzscisoft
Copy link
Collaborator

@kzscisoft kzscisoft commented Aug 11, 2025

Correct Default Window Size for Metric Alerts

Issue: #823

Python Version(s) Tested: 3.13

Operating System(s): Ubuntu 25.04

📝 Summary

Addresses the confusing default of 5 for alert window given a default frequency of 1.

🔄 Changes

Set the default to be None for window, when None the value of frequency is used.

✔️ Checklist

  • Unit and integration tests passing.
  • Pre-commit hooks passing.
  • Quality checks passing.

@kzscisoft kzscisoft linked an issue Aug 11, 2025 that may be closed by this pull request
@kzscisoft kzscisoft requested a review from alahiff August 11, 2025 12:56
@kzscisoft kzscisoft added the bug Something isn't working label Aug 11, 2025
@kzscisoft kzscisoft added this to the Python API v2.2 milestone Aug 11, 2025
@kzscisoft kzscisoft force-pushed the kzscisoft/823-update-confusing-metric-alert-defaults branch from cc66572 to e92065e Compare August 11, 2025 12:58
@kzscisoft kzscisoft merged commit cc7dc36 into dev Aug 13, 2025
20 checks passed
@kzscisoft kzscisoft deleted the kzscisoft/823-update-confusing-metric-alert-defaults branch August 13, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing default window & frequency combination for metrics alerts

2 participants