Wk9874/863 metric name validation #864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@kzscisoft I will need a 2.2.1 python release with this fix (and maybe other bug fixes, TBD) included to allow for the ReMKiT connector work to progress |
Collaborator
Are you sure that these names are allowed? I see unusual characters like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect metric name validation
Issue: #863
Python Version(s) Tested: 3.10
Operating System(s): Ubuntu
📝 Summary
Regex for metric key validation in the python API did not match that in the server (was missing + and parentheses). Updated to match server
🔍 Diagnosis
Bug identified when using ReMKiT connector and parsing variable names like
e-e_odd_C3Il+2_h=2_harmonic_1🔄 Changes
METRIC_KEY_REGEXupdated to match server andlog_metricstests updated to include a metric name with all allowed characters✔️ Checklist