Update typing in Run's __exit__ to match what Python expects#933
Merged
Update typing in Run's __exit__ to match what Python expects#933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tweak typing in
Run's__exit__to satisfy typeshedPython Version(s) Tested: 3.13
Operating System(s): Ubuntu 25.10
📝 Summary
This tweaks the typing of
Run's__exit__function to make it match the typing expected by type-checkers and typeshed, as specifiec eg here: https://github.com/python/typeshed/blob/222da0600fbea86bbc5b3f8c98c24d7ef1ed5187/stdlib/contextlib.pyi#L52🔍 Diagnosis
This issue was found after enabling some extra type-checking on the optSim code (where ty complained that
Runwas not a valid context manager).🔄 Changes
Fixes an error that occurs when running mypy on the code:
error: Argument 3 to "format_exception" has incompatible type "type[BaseException] | BaseException | None"; expected "TracebackType | None" [arg-type]✔️ Checklist