Cleanup unused imports #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sin-ack
requested changes
Sep 3, 2024
Owner
sin-ack
left a comment
sin-ack
left a comment
There was a problem hiding this comment.
Hey, thanks for this! Your tool looks really nice, I'm thinking of making it a pre-commit linter + CI check. One minor issue I spotted is that it removes empty lines after deleted imports aggressively. I think it should only remove a blank line after an import if there are no more imports left (i.e. removing the lines results in double empty lines); otherwise it should preserve the empty lines.
tusharsadhwani
force-pushed
the
unused-imports
branch
from
2238499 to
6b4cb94
Compare
tusharsadhwani
force-pushed
the
unused-imports
branch
from
6b4cb94 to
637e316
Compare
Contributor
Author
|
@sin-ack that has been taken care of, plus now the tool handles all unused global declarations, not just imports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to build an unused import cleaner for Zig, and I ended up using this project as the test-bed for cleaning unused imports and finding edge cases in my implementation.
I'm not sure if such patches are welcome, but I'll just leave a PR here still.
All the test still pass after this changeset, so this shouldn't break anything :)