Skip to content

Start an HTTPS server with 'npm run dev' #1440#1441

Open
iamsin wants to merge 1 commit intomainfrom
1440-start-an-https-server-with-npm-run-dev
Open

Start an HTTPS server with 'npm run dev' #1440#1441
iamsin wants to merge 1 commit intomainfrom
1440-start-an-https-server-with-npm-run-dev

Conversation

@iamsin
Copy link
Contributor

@iamsin iamsin commented Oct 26, 2023

closes #1440

For the Submitter

Tasks

  • Make sure all checkboxes in the Issue content are checked
  • Make sure the PR title is in the format <Issue Title> <Issue Number>
  • Make sure "closes (issue number)" is written close to the top
  • Attach the enhancement label for update tasks
  • Make sure CI completes successfully
  • Check everything written in the PR
  • Fix the issues pointed out by AI
  • Add reviewers
  • On Slack, mention the PR reviewer, write your thoughts on the issue, and inform them that the PR has been created

For the Reviewer

Before Reviewing

  • Write which PR you are reviewing on Slack

Checks

  • Each task for the related issue are written and in checkboxes
  • The branch name is close to the issue name
  • CI completes successfully
  • Changes include only what is necessary for this PR
  • Necessary unit tests are implemented
  • Necessary E2E tests are implemented
  • Perform functionality checks
  • If there are any problems, request revisions from the PR submitter and mention them on Slack

After Reviewing

  • Leave an approval comment (e.g. LGTM)
  • On Slack, mention the PR submitter and a project admin, write which PR you have reviewed, and ask them to merge the PR
  • Write an approval comment with praise on Slack

@iamsin iamsin added the enhancement New feature or request label Oct 26, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit c54aa0d and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

Update Summary

The updates mainly focus on transitioning to HTTPS from HTTP and ignoring HTTPS related errors. Server and Plugins have also been updated accordingly.

playwright.config.ts

  • The baseURL has been updated from http://127.0.0.1:5173${base}/ to https://127.0.0.1:5173${base}/
  • Added a new property ignoreHTTPSErrors and set it to true
  • The url under webServer has been updated from http://127.0.0.1:5173${base}/ to https://127.0.0.1:5173${base}/
  • Added a new property under webServer which is ignoreHTTPSErrors and set it to true

vite.config.ts

  • A new plugin mkcert has been imported
  • The plugins array has been updated to include mkcert()

Suggestions for improvement

playwright.config.ts

  • Ensure the ignoreHTTPSErrors property is set to false in production environment to avoid security threats.
  • While using HTTPS locally is good for a consistent development environment, make sure you have the proper certificates in place.

vite.config.ts

  • Make sure the mkcert plugin is only enabled for development and not for production to avoid any possible security risk.
  • Make sure to handle the certificate creation and usage properly with the mkcert plugin to avoid the "self-signed certificate" warnings.

by OpenAI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Start an HTTPS server with 'npm run dev'

2 participants