Closed
Conversation
Member
Author
|
Note: The test failure on TruffleRuby is fixed by #148. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the Rails pattern into the
mustermanngem.The Rails pattern is the one reason popular gems like Hanami depend on musterman-contrib. It's not a very large class, even with multi-version support, so this would allow Hanami to depend only on Mustermann (and thus also drop the implicit dependency on Hansi – don't get me wrong, love the extra downloads for the stats, but would be great to have fewer people depend on code I'm not actively maintaining).
Opening this and #148 to gather some feedback. Happy to merge them, work on the README (which can use some work anyway) and cut a 3.1 release.