Update documentation to make set behavior a bit clearer#264
Merged
jkowens merged 1 commit intosinatra:masterfrom Feb 25, 2020
Merged
Update documentation to make set behavior a bit clearer#264jkowens merged 1 commit intosinatra:masterfrom
set behavior a bit clearer#264jkowens merged 1 commit intosinatra:masterfrom
Conversation
Member
|
Thanks for the update! |
|
That was fast! 😍 |
Contributor
Author
|
Yow! That was fast! Thanks so much! 💃 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was unclear and tripped us up at work -- we thought
setfunctioned as a memoized deferred-evaluation proc, but that assumption was very, very wrong. This PR updates the documentation to indicate thatsetwith aProcactually evaluates every time the setting is retrieved, as per https://github.com/sinatra/sinatra/blob/a4dd24add24f2dd0e7299b9e68e12038138294d3/lib/sinatra/base.rb#L1221-L1223