Skip to content

Fix syntax highlighting for intro doc#271

Merged
jkowens merged 2 commits intosinatra:masterfrom
kiendang:intro-syntax-highlight
Sep 23, 2020
Merged

Fix syntax highlighting for intro doc#271
jkowens merged 2 commits intosinatra:masterfrom
kiendang:intro-syntax-highlight

Conversation

@kiendang
Copy link
Copy Markdown
Contributor

No description provided.

@jkowens
Copy link
Copy Markdown
Member

jkowens commented Sep 23, 2020

@kiendang could you add an explanation to this PR? I see it's related to syntax highlighting, but why is the change needed?

@kiendang
Copy link
Copy Markdown
Contributor Author

Currently there's no syntax highlighting in the intro doc http://sinatrarb.com/intro.html
The reason is there are 2 methods for syntax highlighting in kramdown: coderay and rouge. For the kramdown version that's currently in use here, coderay will be used if syntax_highlighter is not specified. However the one that's installed alongside jekyll here is rouge, so just by specifying syntax_highlighter => :rouge syntax highlighting is enabled again.

@jkowens jkowens merged commit 53c476e into sinatra:master Sep 23, 2020
@jkowens
Copy link
Copy Markdown
Member

jkowens commented Sep 23, 2020

Looks good, thanks!

@kiendang kiendang deleted the intro-syntax-highlight branch September 23, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants