Conversation
JPPortier
requested review from
650elx,
Dovchik,
asein-sinch and
krogers0607
as code owners
Contributor
Dependency Review✅ No vulnerabilities or license issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned Manifest Files |
JPPortier
force-pushed
the
synch-with-adr-pagination
branch
from
547cfb0 to
da2e54d
Compare
Dovchik
approved these changes
Nov 29, 2023
Dovchik
left a comment
Dovchik
left a comment
There was a problem hiding this comment.
Minor addition about checking there is no items left in iterator
…pages count to detect end of list/pagination. Use dedicated 'SMSCursorPageNavigator' to compute end of list by checking result size against empty list
JPPortier
force-pushed
the
synch-with-adr-pagination
branch
from
da2e54d to
028fcae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create dedicated SMS cursor based navigation to fix issue due to page_size returned value cannot be used to comoute end of navigation