DEVEXP-1093: W35 OAS synch conversation#270
Merged
JPPortier merged 1 commit intofeat/V2.0-nextfrom Aug 29, 2025
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
asein-sinch
approved these changes
Aug 28, 2025
Comment on lines
+1
to
+5
| { | ||
| "channel": "SINCH_CHAT", | ||
| "callback_secret": "callback secret", | ||
| "credential_ordinal_number": 0 | ||
| } |
Contributor
There was a problem hiding this comment.
I know this test is purely for technical validation, but I don't think the API would accept such payload, as there are no credentials associated with this channel. My recommendation would be to revisit this code once the documentation team will have clarified how to handle SINCH_CHAT within this API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.