DEVEXP-348: Refactor conversation events#39
Merged
asein-sinch merged 7 commits intomainfrom Mar 18, 2024
Merged
Conversation
JPPortier
approved these changes
Mar 18, 2024
Dovchik
approved these changes
Mar 18, 2024
Dovchik
left a comment
Dovchik
left a comment
There was a problem hiding this comment.
LGTM, it's a manual edit or you configured generator to generated models with inheritance?
| /** @see CapabilityEventCapabilityNotification */ | ||
| capability_notification?: CapabilityNotification; | ||
| /** Name of the trigger responsible for this event. */ | ||
| trigger: 'CAPABILITY'; |
There was a problem hiding this comment.
Not directly related to PR: How did you figure out the field? From manual testing? I don't see it in oas file nor docs
Collaborator
Author
There was a problem hiding this comment.
trigger is added when parsing the event to set a discriminator. This can then be used by the SDK user to handle the event
Collaborator
Author
It's a manual edit, there are no official specs for events at the moment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.