DEVEXP-782: Numbers API - Active Numbers#53
Merged
matsk-sinch merged 4 commits intov2.0from Mar 25, 2025
Merged
Conversation
Contributor
matsk-sinch
commented
Mar 21, 2025
matsk-sinch
commented
- Update a rented phone number
- Get a rented phone number
- Release a rented phone number
- Update a rented phone number - Get a rented phone number - Release a rented phone number Signed-off-by: Jessica Matsuoka <jessica.akemi.matsuoka@sinch.com>
matsk-sinch
requested review from
Dovchik,
JPPortier,
asein-sinch and
krogers0607
as code owners
matsk-sinch
changed the title
JPPortier
reviewed
Mar 23, 2025
asein-sinch
reviewed
Mar 24, 2025
tests/unit/domains/numbers/v1/models/response/test_active_number_model.py
Show resolved
Hide resolved
tests/unit/domains/numbers/v1/endpoints/active/test_update_active_numbers_endpoint.py
Outdated
Show resolved
Hide resolved
asein-sinch
previously approved these changes
Mar 25, 2025
Contributor
asein-sinch
left a comment
asein-sinch
left a comment
There was a problem hiding this comment.
Well done, one step further towards the final design
asein-sinch
approved these changes
Mar 25, 2025
matsk-sinch
added a commit
that referenced
this pull request
Mar 25, 2026
* DEVEXP-782: Numers API - Active Numbers - Update a rented phone number - Get a rented phone number - Release a rented phone number Signed-off-by: Jessica Matsuoka <jessica.akemi.matsuoka@sinch.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.