Merged
Conversation
asein-sinch
reviewed
Oct 27, 2025
asein-sinch
reviewed
Oct 27, 2025
asein-sinch
reviewed
Oct 27, 2025
asein-sinch
reviewed
Oct 27, 2025
Contributor
asein-sinch
left a comment
asein-sinch
left a comment
There was a problem hiding this comment.
Don't forget to also update the CI to run the E2E tests
sinch/domains/sms/models/v1/internal/base/base_model_configuration.py
Outdated
Show resolved
Hide resolved
sinch/domains/sms/models/v1/internal/base/base_model_configuration.py
Outdated
Show resolved
Hide resolved
asein-sinch
reviewed
Oct 29, 2025
asein-sinch
approved these changes
Oct 29, 2025
matsk-sinch
added a commit
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.