Added Several Utility functions. Fixed error in FindGCD #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull upstream changes
sindrekjr
approved these changes
Dec 10, 2020
Owner
sindrekjr
left a comment
sindrekjr
left a comment
There was a problem hiding this comment.
LGTM! I'm hoping to add some test coverage for these utilities eventually.
Owner
|
Squashed to adhere to conventional commit format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions Added:
ToLongArray(this IEnumerable)Same asToIntArray()but with longsCombinations(this IEnumerable, int subcount)Returns the combinations of lengthsubcountPermutations(this IEnumerable, int subcount)Returns the permutations of lengthsubcountRotate(this IEnumerable)Rotates an array by a number of stepsAllIndexesOf()likeIndexOf()but all instancesUtilities.WriteLine()Writes to bothTraceandConsoleFunctions Modified:
FindGCD(int a, int b)ifb == 0the function would Either recurse infinitely to the point of stack overflow or throw aDivideByZeroExceptionnow exits immediately if either supplied value is 0.General Changes:
default<T> => default