Skip to content

Upgrade package to Node v18#14

Closed
pshenmic wants to merge 2 commits intosindresorhus:mainfrom
pshenmic:feat/node-lts
Closed

Upgrade package to Node v18#14
pshenmic wants to merge 2 commits intosindresorhus:mainfrom
pshenmic:feat/node-lts

Conversation

@pshenmic
Copy link

@pshenmic pshenmic commented Aug 3, 2023

The time has come for the Node v18 and a lot of packages are getting upgraded as it introduces a breaking change - fetch is now bundled and it generally conflicts with node-fetch

This PR upgrades all the npm packages and bumps minimum engine supported

@sindresorhus
Copy link
Owner

The convention in the Node.js community is to support the oldest maintained LTS version, which is currently Node.js 16.

@pshenmic
Copy link
Author

pshenmic commented Aug 5, 2023

Yes dear, but end-of-life of Node v16 will happen like in 1 month, according https://github.com/nodejs/Release
It would be good to have version to upgrade already (I bumped version from v7 to v8 as it is introducing breaking change)
You can always stay on v7 for old applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants