Refactor into generic function#1
Closed
sebastiansandqvist wants to merge 3 commits intosindresorhus:masterfrom
sebastiansandqvist:master
Closed
Refactor into generic function#1sebastiansandqvist wants to merge 3 commits intosindresorhus:masterfrom sebastiansandqvist:master
sebastiansandqvist wants to merge 3 commits intosindresorhus:masterfrom
sebastiansandqvist:master
Conversation
index.js
Outdated
Owner
There was a problem hiding this comment.
If you pass val as the first argument, you could bind it:
module.exports = stable.bind(false);
module.exports.val = stable.bind(true);
Contributor
Author
There was a problem hiding this comment.
That's really elegant--however, I cannot get tests to pass that way. It errors out on stableFn.val() saying "false == true"
Owner
There was a problem hiding this comment.
Oops, I forgot a parameter:
module.exports = stable.bind(null, false);
module.exports.val = stable.bind(null, true);
Owner
|
Excellent. Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two functions
module.exportsandmodule.exports.valwere nearly identical--good candidates for a refactor. The booleanvalfor "value" in thestablefunction should be true if a value is desired for the output and false if a boolean is desired.