Skip to content

Conversation

@raw1z
Copy link
Contributor

@raw1z raw1z commented Oct 24, 2022

When diffview's tab is closed while the commit list is still updating (update can take a few seconds for big repositories), we get an error:

Error executing vim.schedule lua callback: ...diffview/scene/views/file_history/file_history_panel.lua:214: attempt to index field 'option_panel' (a nil value)
stack traceback:
        ...diffview/scene/views/file_history/file_history_panel.lua:214: in function <...diffview/scene/views/file_history/file_history_panel.lua:214>

Copy link
Owner

@sindrets sindrets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sindrets sindrets merged commit 94a3422 into sindrets:main Oct 26, 2022
@sindrets
Copy link
Owner

(update can take a few seconds for big repositories)

@raw1z Multiple seconds? Is that with the default commit limit of 256? What OS is this? For reference, my 6+ year old laptop uses ~500ms to load history for repositories with complex git histories, and ~200ms otherwise.

@raw1z
Copy link
Contributor Author

raw1z commented Oct 27, 2022

I'm on macos. I have an intel mac and a m1 mac. I experience the multiple seconds delay only on the m1 mac for the same repo (https://gitlab.com/raw1z/vim)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants