TDL 19530 update dict based implementation to class based by prijendev · Pull Request #168 · singer-io/tap-github

prijendev · 2022-07-12T08:51:30Z

Description of change

TDL 19530 update dict based implementation to class based

Changed dict-based implementation to class-based implementation.
- Created functionality-wise separate files - schema, discover, sync, streams.
Moved logic of REST API call and error handling to client.py.
Created class for incremental(ordered and unordered), full_table sync.
Created parent class and class for each stream.
Added details code comments for each function.
Added replication key updated_at at 1st level in the schema of the commits stream.
Added separate schema for pr_commits stream.
Added detailed unit test case.
Removed unnecessary unit test case.

TDL-19528 Update parent child relationship

Added implementation to write separate bookmark for child and parent stream.
Tap use a minimum bookmark among the selected parent and its child stream.
Tap write maximum bookmark for all selected parents and its child's stream
Tap write all child records of newly updated parent records.
Tap write replication key value of parent's record in the state of child stream.

Manual QA steps

Risks

Rollback steps

revert this branch

… in config

dbshah1212 · 2022-07-12T09:43:21Z

.circleci/config.yml

          command: |
            source /usr/local/share/virtualenvs/tap-github/bin/activate
-            pylint tap_github --disable 'missing-module-docstring,missing-function-docstring,missing-class-docstring,line-too-long,invalid-name,too-many-lines,consider-using-f-string,too-many-arguments,too-many-locals'
+            pylint tap_github --disable 'missing-module-docstring,missing-function-docstring,missing-class-docstring,line-too-long,invalid-name,too-many-lines,consider-using-f-string,too-many-arguments,too-many-locals,no-else-return,no-self-use'


As we refactored the tap, why can't we resolve the max possible?

Removed extra disabled pylint.

dbshah1212 · 2022-07-12T09:46:46Z

tap_github/client.py

+    }
+}
+
+def raise_for_error(resp, source):


Add function comment

Added function comment

tap_github/client.py

…ed' of https://github.com/singer-io/tap-github into TDL-19527-update-backoff-error-handling

tap_github/__init__.py

dbshah1212 · 2022-07-13T10:15:37Z

tap_github/client.py

+
+                    LOGGER.info("Verifying access of repository: %s", repo_full_name)
+                    self.verify_repo_access(
+                        'https://api.github.com/repos/{}/commits'.format(repo_full_name),


We are using this URL twice, is it possible to define this in one variable?

Defined URL in single variable base_url.

dbshah1212 · 2022-07-13T10:20:07Z

tap_github/streams.py

+    return full_url
+
+
+class Stream:


Add Class doc

Added doc string.

…andling' into TDl-19530-update-dict-based-implementation-to-class-based

…update-dict-based-implementation-to-class-based

kspeer825

Integration tests look good 👍

* Initial commit. * Updated unittest case and resolved pylints. * Defined orgs streams in constant. * Updated extract_repo_from_config method. * Updated unit test cases. * Added back unittest cases. * TDL-19555 added missing test cases and updated test cases according to code change (#167) * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * unskipped incremental child streams from assertion * updated base.py * resolved review comments * resolved review comment * update variable name * resolved review comment and updated print - LOGGER * Reverted back changes of all field test case. Co-authored-by: NevilParikh14 <92399024+NevilParikh14@users.noreply.github.com>

* Initial commit. * Removed url from the stream class. * Updated readme and sample config. * Updated sync test to utilize custom domain config parameter `base_url`. * Updated test_stream unit test. * Removed duplicate comment. * Added support of empty string in custom domain. Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasys.com>

* TDL-12323 Implemented currently syncing for repos and streams * resolved PR review comments * TDL-19980 fixed the bug * fixed the bug when any stream not selected, but the state writes currenctly_syncing * resolved PR comments * resolved pylint * fixed cci issue * fixed cci issues * fixing cci issue * resolved cci issues * fixed cci issue * made cci happy * updated one assertion and comments

* TDL-19555 added missing test cases and updated test cases according to code change (#167) * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * unskipped incremental child streams from assertion * updated base.py * resolved review comments * resolved review comment * update variable name * resolved review comment and updated print - LOGGER * TDL 19530 update dict based implementation to class based (#168) * added backoff for 5xx error and fixed indexerror when only passed org in config * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * Initial commit. * Removed unnecessary unit test cases. * updated code comments * Resolved pylint errors. * disabled pylint for get_child_records. * Added unittest cases. * Added filter params for commits and comments stream. * Updated unit test cases. * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * Updated bookmark logic for parent child streams. * Updated credentials check logic. * Updated unittest case. * Resolved PR comments and handled error for / in repository in config * added unittests for only / in config * Updated client.py to raise error for wrong org. * Added back creds check logic during object creation time. * handled the /repo and raised exception with a list * unskipped incremental child streams from assertion * Make pk of child automatic in parent stream. * updated unittests * Added logger message to print url for all streams. * updated base.py * Skipped 404 error for all streams. * Removed unnecessary __exit__ method from client * Updated doc link for each stream. * removed duplicates from extract_repos_from_config() and thrown warning message for duplicate repos * resolved PR comments and fixed pylint * Added __exit__ method in the Client object. * Added new line in the end of client.py * Updated schema for pr_commits. * resolved PR comments * Give warning message for invalid repo. * Added comments in the code. * resolved PR comments * resolved review comments * Raised error for invalid organization. * Updated logger message in client.py * Updated unittest case to use parameterized. * added a new TooManyRequests class error for 429 * resolved review comment * update variable name * resolved review comment and updated print - LOGGER * TDL 16573 sync teams at organization level (#173) * Initial commit. * Updated unittest case and resolved pylints. * Defined orgs streams in constant. * Updated extract_repo_from_config method. * Updated unit test cases. * Added back unittest cases. * TDL-19555 added missing test cases and updated test cases according to code change (#167) * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * unskipped incremental child streams from assertion * updated base.py * resolved review comments * resolved review comment * update variable name * resolved review comment and updated print - LOGGER * Reverted back changes of all field test case. Co-authored-by: NevilParikh14 <92399024+NevilParikh14@users.noreply.github.com> * TDL-5961 Support of custom domain (#172) * Initial commit. * Removed url from the stream class. * Updated readme and sample config. * Updated sync test to utilize custom domain config parameter `base_url`. * Updated test_stream unit test. * Removed duplicate comment. * Added support of empty string in custom domain. Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasys.com> * TDL-12323 Implemented currently syncing for repos and streams (#171) * TDL-12323 Implemented currently syncing for repos and streams * resolved PR review comments * TDL-19980 fixed the bug * fixed the bug when any stream not selected, but the state writes currenctly_syncing * resolved PR comments * resolved pylint * fixed cci issue * fixed cci issues * fixing cci issue * resolved cci issues * fixed cci issue * made cci happy * updated one assertion and comments * Updated verify_access_for_repo method in client. * Resolved pylint. * Updated currently syncing for teams streams. (#174) Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasys.com> Co-authored-by: NevilParikh14 <nevil.parikh@crestdatasys.com> Co-authored-by: NevilParikh14 <92399024+NevilParikh14@users.noreply.github.com> Co-authored-by: namrata270998 <75604662+namrata270998@users.noreply.github.com> * Tdl 20302 add query param for pull requests (#175) * Added query param for pull_requests streams. * Updated unit test for pull_requests. * Updated interrupted sync test case. * Updated tap-tester for interupted sync. * TDL-19526 added missing fields (#170) * added backoff for 5xx error and fixed indexerror when only passed org in config * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * Initial commit. * Removed unnecessary unit test cases. * updated code comments * Resolved pylint errors. * disabled pylint for get_child_records. * Added unittest cases. * Added filter params for commits and comments stream. * Updated unit test cases. * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * added missing fields * Updated bookmark logic for parent child streams. * Updated credentials check logic. * Updated unittest case. * Resolved PR comments and handled error for / in repository in config * added unittests for only / in config * Updated client.py to raise error for wrong org. * Added back creds check logic during object creation time. * removed extra formatting * improved formatting * handled the /repo and raised exception with a list * unskipped incremental child streams from assertion * Make pk of child automatic in parent stream. * updated unittests * Added logger message to print url for all streams. * updated base.py * Skipped 404 error for all streams. * Removed unnecessary __exit__ method from client * Updated doc link for each stream. * removed duplicates from extract_repos_from_config() and thrown warning message for duplicate repos * resolved PR comments and fixed pylint * resolved pr comments * Added __exit__ method in the Client object. * added more fields to shared schema * removed additionalproperties as duplicate * Added new line in the end of client.py * added user to shared schema * updated indentation * Resolved PR review comments * resolved pr comments * added more references * added ref for assignees * removed description * added ref schema to reactions * fixed type of total count in reactions * removed indentation from team_members and commits * Updated schema for pr_commits. * removed _sdc_repo from users.json * removed commits from shared schema and added the original schema back * resolved PR comments * Give warning message for invalid repo. * Added comments in the code. * updated indentation * updated ref * resolved PR comments * resolved review comments * Raised error for invalid organization. * Updated logger message in client.py * Updated unittest case to use parameterized. * added missing fields * removed shared schema for some fields * added missing fields * added missing fields * reverted the type of some fields * removed extra ',' from schema * added missing fields in the KNOWN_MISSING_FIELDS for all_fields * added a new TooManyRequests class error for 429 * added missing fields in the schema * added draft in missing fields * updated indentation * updated indentation level * removed extra fields from commit->committer * added author and stats in pr_commits * added misisng field in all_fields * updated the string schema type to obj as per api doc * resolved review comment * update variable name * added string in changed object type for backup * resolved review comment and updated print - LOGGER * used shared schema for performed_via_github_app and added ref back inissue_events stream * fixed typo * TDL-14359 added properties to issue assignees (#169) * added properties to issue assignees * updated issues schema * resolved review comments * added assignees in shared schema * updated assignee to user as same schema * deleted shared assignees * reverted back to number for some schemas * removed extra',' from schema * copied the base branch fields back to assignees schema * removed additionalProperties from user.json * updated indentation level * updated indentation level * TDL 16573 sync teams at organization level (#173) * Initial commit. * Updated unittest case and resolved pylints. * Defined orgs streams in constant. * Updated extract_repo_from_config method. * Updated unit test cases. * Added back unittest cases. * TDL-19555 added missing test cases and updated test cases according to code change (#167) * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * unskipped incremental child streams from assertion * updated base.py * resolved review comments * resolved review comment * update variable name * resolved review comment and updated print - LOGGER * Reverted back changes of all field test case. Co-authored-by: NevilParikh14 <92399024+NevilParikh14@users.noreply.github.com> * TDL-5961 Support of custom domain (#172) * Initial commit. * Removed url from the stream class. * Updated readme and sample config. * Updated sync test to utilize custom domain config parameter `base_url`. * Updated test_stream unit test. * Removed duplicate comment. * Added support of empty string in custom domain. Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasys.com> * TDL-12323 Implemented currently syncing for repos and streams (#171) * TDL-12323 Implemented currently syncing for repos and streams * resolved PR review comments * TDL-19980 fixed the bug * fixed the bug when any stream not selected, but the state writes currenctly_syncing * resolved PR comments * resolved pylint * fixed cci issue * fixed cci issues * fixing cci issue * resolved cci issues * fixed cci issue * made cci happy * updated one assertion and comments * Updated verify_access_for_repo method in client. * Resolved pylint. * Updated currently syncing for teams streams. (#174) * made schema type in a single line * fixed cci issue * added date-time format for closed_at in issue_events.json Co-authored-by: NevilParikh14 <nevil.parikh@crestdatasys.com> Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com> Co-authored-by: Prijen Khokhani <88327452+prijendev@users.noreply.github.com> Co-authored-by: NevilParikh14 <92399024+NevilParikh14@users.noreply.github.com> * TDL-20336 custom domain which are not created as a part of Github results into key error (#177) * Raise exception if `X-RateLimit-Reset` is not found in the header. * Updated comment in the unit test. * TDL 20339 handle empty bookmark if all repos unselected for next sync. (#178) * Handle empty bookmark if all existing repos are unselected. * Added detailed comments and unit test. * Added more comments. * Updated variable name and comments. * Updated comment. * Updated logic to return existing state. * Updated variable name and function name in unit test. * Removed duplicate field in the team_membership schema. Co-authored-by: NevilParikh14 <92399024+NevilParikh14@users.noreply.github.com> Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasys.com> Co-authored-by: NevilParikh14 <nevil.parikh@crestdatasys.com> Co-authored-by: namrata270998 <75604662+namrata270998@users.noreply.github.com>

* TDL-19555 added missing test cases and updated test cases according to code change (singer-io#167) * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * unskipped incremental child streams from assertion * updated base.py * resolved review comments * resolved review comment * update variable name * resolved review comment and updated print - LOGGER * TDL 19530 update dict based implementation to class based (singer-io#168) * added backoff for 5xx error and fixed indexerror when only passed org in config * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * Initial commit. * Removed unnecessary unit test cases. * updated code comments * Resolved pylint errors. * disabled pylint for get_child_records. * Added unittest cases. * Added filter params for commits and comments stream. * Updated unit test cases. * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * Updated bookmark logic for parent child streams. * Updated credentials check logic. * Updated unittest case. * Resolved PR comments and handled error for / in repository in config * added unittests for only / in config * Updated client.py to raise error for wrong org. * Added back creds check logic during object creation time. * handled the /repo and raised exception with a list * unskipped incremental child streams from assertion * Make pk of child automatic in parent stream. * updated unittests * Added logger message to print url for all streams. * updated base.py * Skipped 404 error for all streams. * Removed unnecessary __exit__ method from client * Updated doc link for each stream. * removed duplicates from extract_repos_from_config() and thrown warning message for duplicate repos * resolved PR comments and fixed pylint * Added __exit__ method in the Client object. * Added new line in the end of client.py * Updated schema for pr_commits. * resolved PR comments * Give warning message for invalid repo. * Added comments in the code. * resolved PR comments * resolved review comments * Raised error for invalid organization. * Updated logger message in client.py * Updated unittest case to use parameterized. * added a new TooManyRequests class error for 429 * resolved review comment * update variable name * resolved review comment and updated print - LOGGER * TDL 16573 sync teams at organization level (singer-io#173) * Initial commit. * Updated unittest case and resolved pylints. * Defined orgs streams in constant. * Updated extract_repo_from_config method. * Updated unit test cases. * Added back unittest cases. * TDL-19555 added missing test cases and updated test cases according to code change (singer-io#167) * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * unskipped incremental child streams from assertion * updated base.py * resolved review comments * resolved review comment * update variable name * resolved review comment and updated print - LOGGER * Reverted back changes of all field test case. Co-authored-by: NevilParikh14 <92399024+NevilParikh14@users.noreply.github.com> * TDL-5961 Support of custom domain (singer-io#172) * Initial commit. * Removed url from the stream class. * Updated readme and sample config. * Updated sync test to utilize custom domain config parameter `base_url`. * Updated test_stream unit test. * Removed duplicate comment. * Added support of empty string in custom domain. Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasys.com> * TDL-12323 Implemented currently syncing for repos and streams (singer-io#171) * TDL-12323 Implemented currently syncing for repos and streams * resolved PR review comments * TDL-19980 fixed the bug * fixed the bug when any stream not selected, but the state writes currenctly_syncing * resolved PR comments * resolved pylint * fixed cci issue * fixed cci issues * fixing cci issue * resolved cci issues * fixed cci issue * made cci happy * updated one assertion and comments * Updated verify_access_for_repo method in client. * Resolved pylint. * Updated currently syncing for teams streams. (singer-io#174) Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasys.com> Co-authored-by: NevilParikh14 <nevil.parikh@crestdatasys.com> Co-authored-by: NevilParikh14 <92399024+NevilParikh14@users.noreply.github.com> Co-authored-by: namrata270998 <75604662+namrata270998@users.noreply.github.com> * Tdl 20302 add query param for pull requests (singer-io#175) * Added query param for pull_requests streams. * Updated unit test for pull_requests. * Updated interrupted sync test case. * Updated tap-tester for interupted sync. * TDL-19526 added missing fields (singer-io#170) * added backoff for 5xx error and fixed indexerror when only passed org in config * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * Initial commit. * Removed unnecessary unit test cases. * updated code comments * Resolved pylint errors. * disabled pylint for get_child_records. * Added unittest cases. * Added filter params for commits and comments stream. * Updated unit test cases. * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * added missing fields * Updated bookmark logic for parent child streams. * Updated credentials check logic. * Updated unittest case. * Resolved PR comments and handled error for / in repository in config * added unittests for only / in config * Updated client.py to raise error for wrong org. * Added back creds check logic during object creation time. * removed extra formatting * improved formatting * handled the /repo and raised exception with a list * unskipped incremental child streams from assertion * Make pk of child automatic in parent stream. * updated unittests * Added logger message to print url for all streams. * updated base.py * Skipped 404 error for all streams. * Removed unnecessary __exit__ method from client * Updated doc link for each stream. * removed duplicates from extract_repos_from_config() and thrown warning message for duplicate repos * resolved PR comments and fixed pylint * resolved pr comments * Added __exit__ method in the Client object. * added more fields to shared schema * removed additionalproperties as duplicate * Added new line in the end of client.py * added user to shared schema * updated indentation * Resolved PR review comments * resolved pr comments * added more references * added ref for assignees * removed description * added ref schema to reactions * fixed type of total count in reactions * removed indentation from team_members and commits * Updated schema for pr_commits. * removed _sdc_repo from users.json * removed commits from shared schema and added the original schema back * resolved PR comments * Give warning message for invalid repo. * Added comments in the code. * updated indentation * updated ref * resolved PR comments * resolved review comments * Raised error for invalid organization. * Updated logger message in client.py * Updated unittest case to use parameterized. * added missing fields * removed shared schema for some fields * added missing fields * added missing fields * reverted the type of some fields * removed extra ',' from schema * added missing fields in the KNOWN_MISSING_FIELDS for all_fields * added a new TooManyRequests class error for 429 * added missing fields in the schema * added draft in missing fields * updated indentation * updated indentation level * removed extra fields from commit->committer * added author and stats in pr_commits * added misisng field in all_fields * updated the string schema type to obj as per api doc * resolved review comment * update variable name * added string in changed object type for backup * resolved review comment and updated print - LOGGER * used shared schema for performed_via_github_app and added ref back inissue_events stream * fixed typo * TDL-14359 added properties to issue assignees (singer-io#169) * added properties to issue assignees * updated issues schema * resolved review comments * added assignees in shared schema * updated assignee to user as same schema * deleted shared assignees * reverted back to number for some schemas * removed extra',' from schema * copied the base branch fields back to assignees schema * removed additionalProperties from user.json * updated indentation level * updated indentation level * TDL 16573 sync teams at organization level (singer-io#173) * Initial commit. * Updated unittest case and resolved pylints. * Defined orgs streams in constant. * Updated extract_repo_from_config method. * Updated unit test cases. * Added back unittest cases. * TDL-19555 added missing test cases and updated test cases according to code change (singer-io#167) * added missing test cases and updated test cases according to code change * removed tags stream as it is not yet added * Updated inturrupted sync assertion * Removed bookmark conversion to utc * updated inerrupted sync assertions * resolved review comments * updated sreams in parent-child test case * resolved review comments * resolved review comments * Updated start_date test * updated date format conversion in test * unskipped incremental child streams from assertion * updated base.py * resolved review comments * resolved review comment * update variable name * resolved review comment and updated print - LOGGER * Reverted back changes of all field test case. Co-authored-by: NevilParikh14 <92399024+NevilParikh14@users.noreply.github.com> * TDL-5961 Support of custom domain (singer-io#172) * Initial commit. * Removed url from the stream class. * Updated readme and sample config. * Updated sync test to utilize custom domain config parameter `base_url`. * Updated test_stream unit test. * Removed duplicate comment. * Added support of empty string in custom domain. Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasys.com> * TDL-12323 Implemented currently syncing for repos and streams (singer-io#171) * TDL-12323 Implemented currently syncing for repos and streams * resolved PR review comments * TDL-19980 fixed the bug * fixed the bug when any stream not selected, but the state writes currenctly_syncing * resolved PR comments * resolved pylint * fixed cci issue * fixed cci issues * fixing cci issue * resolved cci issues * fixed cci issue * made cci happy * updated one assertion and comments * Updated verify_access_for_repo method in client. * Resolved pylint. * Updated currently syncing for teams streams. (singer-io#174) * made schema type in a single line * fixed cci issue * added date-time format for closed_at in issue_events.json Co-authored-by: NevilParikh14 <nevil.parikh@crestdatasys.com> Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com> Co-authored-by: Prijen Khokhani <88327452+prijendev@users.noreply.github.com> Co-authored-by: NevilParikh14 <92399024+NevilParikh14@users.noreply.github.com> * TDL-20336 custom domain which are not created as a part of Github results into key error (singer-io#177) * Raise exception if `X-RateLimit-Reset` is not found in the header. * Updated comment in the unit test. * TDL 20339 handle empty bookmark if all repos unselected for next sync. (singer-io#178) * Handle empty bookmark if all existing repos are unselected. * Added detailed comments and unit test. * Added more comments. * Updated variable name and comments. * Updated comment. * Updated logic to return existing state. * Updated variable name and function name in unit test. * Removed duplicate field in the team_membership schema. Co-authored-by: NevilParikh14 <92399024+NevilParikh14@users.noreply.github.com> Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasys.com> Co-authored-by: NevilParikh14 <nevil.parikh@crestdatasys.com> Co-authored-by: namrata270998 <75604662+namrata270998@users.noreply.github.com>

namrata270998 and others added 10 commits July 1, 2022 06:53

added backoff for 5xx error and fixed indexerror when only passed org…

e059953

… in config

added missing test cases and updated test cases according to code change

66f2f2b

removed tags stream as it is not yet added

3549178

Updated inturrupted sync assertion

dc82926

Removed bookmark conversion to utc

79d8209

updated inerrupted sync assertions

a2d2b0d

resolved review comments

5442073

updated sreams in parent-child test case

ad1e6fd

Initial commit.

e55bba9

Removed unnecessary unit test cases.

709fdcd

prijendev requested review from dbshah1212, karanpanchal-crest and savan-chovatiya July 12, 2022 09:30

dbshah1212 reviewed Jul 12, 2022

View reviewed changes

tap_github/client.py Show resolved Hide resolved

updated code comments

f5245f9

namrata270998 self-requested a review July 12, 2022 10:06

prijendev mentioned this pull request Jul 12, 2022

pull_requests since bookmark overrides that of reviews and review_comments #59

Closed

namrata270998 requested a review from dbshah1212 July 12, 2022 10:47

prijendev and others added 7 commits July 12, 2022 16:55

Resolved pylint errors.

713ccee

disabled pylint for get_child_records.

b724ea0

Merge branch 'TDl-19530-update-dict-based-implementation-to-class-bas…

654b7b1

…ed' of https://github.com/singer-io/tap-github into TDL-19527-update-backoff-error-handling

Added unittest cases.

4fd734b

Added filter params for commits and comments stream.

b72464e

Updated unit test cases.

9c05ebe

resolved review comments

88a7eb3

dbshah1212 reviewed Jul 13, 2022

View reviewed changes

tap_github/__init__.py Show resolved Hide resolved

dbshah1212 reviewed Jul 13, 2022

View reviewed changes

prijendev added 2 commits July 22, 2022 14:40

Updated logger message in client.py

ca8fdae

Merge remote-tracking branch 'origin/TDL-19527-update-backoff-error-h…

80d0080

…andling' into TDl-19530-update-dict-based-implementation-to-class-based

dbshah1212 approved these changes Jul 22, 2022

View reviewed changes

dbshah1212 requested review from KrisPersonal, RushiT0122, kspeer825 and luandy64 July 25, 2022 04:16

prijendev and others added 8 commits July 25, 2022 15:46

Updated unittest case to use parameterized.

e2c1840

added a new TooManyRequests class error for 429

b18f699

resolved review comment

9fbe579

Merge branch 'TDL-19555-add-missing-tap-tester-tests' into TDl-19530-…

67adc29

…update-dict-based-implementation-to-class-based

update variable name

a024fba

Merge branch 'TDL-19555-add-missing-tap-tester-tests' into TDl-19530-…

9e47b6c

…update-dict-based-implementation-to-class-based

resolved review comment and updated print - LOGGER

83b1e5b

Merge branch 'TDL-19555-add-missing-tap-tester-tests' into TDl-19530-…

b1edb4f

…update-dict-based-implementation-to-class-based

prijendev changed the base branch from TDL-19555-add-missing-tap-tester-tests to crest-master August 5, 2022 08:58

kspeer825 approved these changes Aug 5, 2022

View reviewed changes

prijendev and others added 4 commits August 8, 2022 17:20

Updated verify_access_for_repo method in client.

8620298

prijendev requested a review from bryantgray August 8, 2022 16:35

Resolved pylint.

b0c9d6b

bryantgray approved these changes Aug 8, 2022

View reviewed changes

prijendev and others added 2 commits August 9, 2022 11:05

Updated currently syncing for teams streams. (#174)

affbfc0

backmerged main branch

35f65dc

prijendev merged commit 60bf801 into crest-master Aug 10, 2022

prijendev mentioned this pull request Aug 12, 2022

Crest master #176

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TDL 19530 update dict based implementation to class based#168

TDL 19530 update dict based implementation to class based#168
prijendev merged 70 commits intocrest-masterfrom
TDl-19530-update-dict-based-implementation-to-class-based

prijendev commented Jul 12, 2022 •

edited

Loading

Uh oh!

dbshah1212 Jul 12, 2022

Uh oh!

prijendev Jul 12, 2022

Uh oh!

dbshah1212 Jul 12, 2022

Uh oh!

namrata270998 Jul 12, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

dbshah1212 Jul 13, 2022

Uh oh!

prijendev Jul 14, 2022

Uh oh!

dbshah1212 Jul 13, 2022

Uh oh!

prijendev Jul 14, 2022

Uh oh!

kspeer825 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

prijendev commented Jul 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of change

Manual QA steps

Risks

Rollback steps

Uh oh!

dbshah1212 Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

prijendev Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

dbshah1212 Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

namrata270998 Jul 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dbshah1212 Jul 13, 2022

Choose a reason for hiding this comment

Uh oh!

prijendev Jul 14, 2022

Choose a reason for hiding this comment

Uh oh!

dbshah1212 Jul 13, 2022

Choose a reason for hiding this comment

Uh oh!

prijendev Jul 14, 2022

Choose a reason for hiding this comment

Uh oh!

kspeer825 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

prijendev commented Jul 12, 2022 •

edited

Loading

namrata270998 Jul 12, 2022 •

edited

Loading