Fix sub_stream to enable 'reviews'#47
Merged
KAllan357 merged 3 commits intosinger-io:masterfrom Jan 11, 2019
Merged
Conversation
…nly returns review_comments. This change allows for it to return both reviews and reviews_comments so it can properly iterate through both substreams.
Contributor
|
Hi @kdetto, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
Contributor
|
You did it @kdetto! Thank you for signing the Singer Contribution License Agreement. |
KAllan357
suggested changes
Jan 9, 2019
tap_github.py
Outdated
| singer.write_schema(sub_stream_id, sub_stream['schema'], | ||
| sub_stream['key_properties']) | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
This seems unintentional - please remove.
Contributor
Author
There was a problem hiding this comment.
Removed the whitespace.
Contributor
Author
|
Is there anything else we need to do to get this merged? I had tested this locally and the tap returned 'reviews'. We have stakeholders asking for an ETA on this data being available, so anything I can communicate back to them would be great! |
KAllan357
approved these changes
Jan 11, 2019
Contributor
|
Released this in v1.3.4 |
AJWurts
pushed a commit
to villagelabsco/tap-github
that referenced
this pull request
Oct 24, 2024
* Fixes the tap to sync reviews. The sub_streams dictionary currently only returns review_comments. This change allows for it to return both reviews and reviews_comments so it can properly iterate through both substreams. * Removing print statement used in testin. * Removes some whitespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the tap to enable the sync of 'reviews'. The sub_streams dictionary currently only returns 'review_comments'. This change allows for it to return both 'reviews' and 'review_comments' so it can properly iterate through both substreams.