Fix issue 83, projects.json and pull_request_reviews.json#87
Merged
KAllan357 merged 2 commits intosinger-io:masterfrom Aug 10, 2020
Merged
Fix issue 83, projects.json and pull_request_reviews.json#87KAllan357 merged 2 commits intosinger-io:masterfrom
KAllan357 merged 2 commits intosinger-io:masterfrom
Conversation
added 2 commits
July 28, 2020 15:23
Fix [issue 83](singer-io#83) by removing `format: date-time` from `html_url` field in `projects.json`.
Fix format: date-time from pull_request_url and href fields in pul_request_reviews.json
jeffhuth-bytecode
changed the title
jacobrobertbaca
approved these changes
Aug 10, 2020
KAllan357
approved these changes
Aug 10, 2020
AJWurts
pushed a commit
to villagelabsco/tap-github
that referenced
this pull request
Oct 24, 2024
* Fix issue 83: projects.json Fix [issue 83](singer-io#83) by removing `format: date-time` from `html_url` field in `projects.json`. * Fix pull_request_reviews.json format Fix format: date-time from pull_request_url and href fields in pul_request_reviews.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Fix issue 83 by removing
format: date-timefromhtml_urlfield inprojects.jsonandpull_request_urlandhreffields inpull_request_reviews.json.Manual QA steps
Removed format param, ran discovery and sync. No issues.
Risks
Low - very minor change to field in JSON schema.
Rollback steps
Revert to 1.8.1