Conversation
Previously, the options object returned by `singleSpaAngular()` stored lifecycle state (`bootstrappedRef`, `bootstrappedNgZone`, `routingEventListener`) as flat singleton properties. When the same parcel config was passed to `mountRootParcel()` more than once, all instances shared this state, causing only one parcel to function correctly. Fixes this by introducing a per-instance `instances` map on the options object, keyed by `props.name || props.appName`. Each call to `bootstrap`, `mount`, and `unmount` now reads and writes its own `BootstrappedInstanceRef` entry, so multiple parcels using the same config are fully independent. This mirrors the fix applied to single-spa-react in single-spa/single-spa-react#68 and follows the pattern originally suggested in the issue. Closes #234
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the options object returned by
singleSpaAngular()stored lifecycle state (bootstrappedRef,bootstrappedNgZone,routingEventListener) as flat singleton properties. When the same parcel config was passed tomountRootParcel()more than once, all instances shared this state, causing only one parcel to function correctly.Fixes this by introducing a per-instance
instancesmap on the options object, keyed byprops.name || props.appName. Each call tobootstrap,mount, andunmountnow reads and writes its ownBootstrappedInstanceRefentry, so multiple parcels using the same config are fully independent.This mirrors the fix applied to single-spa-react in single-spa/single-spa-react#68 and follows the pattern originally suggested in the issue.
Closes #234