Fix otel log export #49
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug which is preventing otel logs from being exported correctly is addressed in this PR.
The
logging.basicConfigwas being called with a handlers argument, which can interfere with the OpenTelemetry logging setup if a handler is already configured on the root logger.The root of the problem was a conflict in how Python's standard logging module was being configured within the main.py file.
In Python, there are two main ways to configure the logging system:
Manually: By getting a logger object (like the root logger) and directly adding handlers to it (e.g., logging.root.addHandler(...)).Convenience Function: Using logging.basicConfig(...), which is a helper for simple, one-time configuration of the root logger.basicConfigonly works if the root logger has no handlers configured yet. If we call it after a handler has already been added, it does nothing.Testing
Tested with custom agent, testing with Analyst pending.
JIRA
https://memsql.atlassian.net/browse/MCDB-84204