Skip to content

propagates promiseLibrary to new stub behaviors#1484

Merged
mroderick merged 1 commit intosinonjs:masterfrom
HugoMuller:issue-1474
Jul 13, 2017
Merged

propagates promiseLibrary to new stub behaviors#1484
mroderick merged 1 commit intosinonjs:masterfrom
HugoMuller:issue-1474

Conversation

@HugoMuller
Copy link
Contributor

Purpose (TL;DR) - mandatory

Fix issue #1474 by copying stub promiseLibrary to its new behaviors.

Background (Problem in detail) - optional

The problem was that stub behaviors created with onCall, did not preserve the promise library defined when calling usingPromise on the original stub.

Solution - optional

Extending the new behavior with the promiseLibrary from the stub.defaultBehavior solves the issue.

How to verify - mandatory

  1. Check out this branch (see github instructions below)
  2. npm install
  3. npm test

@coveralls
Copy link

coveralls commented Jul 12, 2017

Coverage Status

Coverage increased (+0.004%) to 95.002% when pulling d14d296 on HugoMuller:issue-1474 into 9365d49 on sinonjs:master.

@mroderick
Copy link
Member

Thank you for your contribution 💯

@mroderick
Copy link
Member

This has become v2.3.8

@mroderick mroderick added the semver:patch changes will cause a new patch version label Jul 13, 2017
@HugoMuller HugoMuller deleted the issue-1474 branch July 26, 2017 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:patch changes will cause a new patch version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants