Make all properties non-enumerable in spies, stubs, mocks and fakes#1975
Merged
fatso83 merged 1 commit intosinonjs:masterfrom Feb 18, 2019
ehmicky:master
Merged
Make all properties non-enumerable in spies, stubs, mocks and fakes#1975fatso83 merged 1 commit intosinonjs:masterfrom ehmicky:master
fatso83 merged 1 commit intosinonjs:masterfrom
ehmicky:master
Conversation
Pull Request Test Coverage Report for Build 2789
💛 - Coveralls |
fatso83
approved these changes
Feb 8, 2019
Contributor
fatso83
left a comment
There was a problem hiding this comment.
Very nice! This looks fine to me, as the diff is very understandable. Haven't tested it, though.
Not sure this change validates a test or not, as this should be a non-functional change.
Member
|
Thank you ❤️ |
papandreou
added a commit
to unexpectedjs/unexpected-sinon
that referenced
this pull request
Feb 19, 2019
They aren't as of sinonjs/sinon#1975, which landed in sinon 7.2.4 Fixes #92
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Fix issue #1936 by making all properties non-enumerable in spies, stubs, mocks and fakes.
How to verify - mandatory
npm installsinon.spy(),sinon.stub(),sinon.fake(),sinon.mock()should not return non-enumerable properties.Very few properties had to be left because removing them was breaking the tests.
Also this is a breaking change (major version) because some users might rely on spy/stub/fake/mock properties being enumerable.
CircleCI on Node 10 fails but this does not seem related to this PR, as it failed on other commits/PRs.
Checklist for author
npm run lintpasses