Fix lost links, formatting, and indentation in the migration guide#2649
Merged
mroderick merged 2 commits intosinonjs:mainfrom Mar 20, 2025
Merged
Fix lost links, formatting, and indentation in the migration guide#2649mroderick merged 2 commits intosinonjs:mainfrom
mroderick merged 2 commits intosinonjs:mainfrom
Conversation
Contributor
Krinkle
commented
Mar 20, 2025
Krinkle
commented
- The links became unclickable plain text.
- The code blocks became unformatted and unintented.
The links had became unclickable plain text. The code blocks became unformatted and unintented.
There used to be a link from the word "changed" to https://sinonjs.org/fake-timers per [1]. This link was removed, which seems fine, but the full stop after it was also removed. [1]: https://web.archive.org/web/20210307205357/https://sinonjs.org/guides/migrating-to-3.0
mroderick
approved these changes
Mar 20, 2025
Member
mroderick
left a comment
mroderick
left a comment
There was a problem hiding this comment.
Thank you :)
The changes will be published on the website, once the next release goes out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.