Skip to content

Add more strictness #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cjohansen merged 1 commit into from
Nov 15, 2014
Merged

Add more strictness #602

cjohansen merged 1 commit into from
Nov 15, 2014

Conversation

@mantoni
Copy link
Member

@mantoni mantoni commented Nov 15, 2014

  • More "use strict";
  • Use === and !== where possible
  • Compare with undefined instead of typeof x === "undefined"
  • Remove unnecessary else
  • Define globals

@mantoni mantoni force-pushed the sinon-2.0-more-strict branch from 2a73eaf to 3c2ebbd Compare November 15, 2014 16:27
cjohansen added a commit that referenced this pull request Nov 15, 2014
@cjohansen
Merge pull request #602 from cjohansen/sinon-2.0-more-strict
6ae39c6 
Add more strictness
@cjohansen cjohansen merged commit 6ae39c6 into sinon-2.0 Nov 15, 2014
@cjohansen
Copy link
Contributor

cjohansen commented Nov 15, 2014

👍

@mantoni mantoni deleted the sinon-2.0-more-strict branch October 6, 2015 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mantoni @cjohansen