Additional constructors for TwoLevelTree#77
Merged
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Member
|
If you are into fixing docs, there is an unfinished sentence in the documentation for |
trulsf
reviewed
Oct 10, 2025
trulsf
reviewed
Oct 10, 2025
trulsf
approved these changes
Oct 10, 2025
Co-authored-by: Truls Flatberg <75753981+trulsf@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ass outlined in #75, it could be beneficial to add additional constructors for
TwoLevelTree. This version implements in practice the outlined version, although I did a few modifications to be clear how the constructors can be used. I also representregular_treein the new design.Important
The system itself could be adjusted now. Some functionality was retained to maintain backward compatibility:
regular_treeas the new structure is based on a constructor forTwoLevelTree.TwoLevelTreeis mutable with the new design.These things should be, in my opinion, adjusted in the next breaking release.
This PR closes #75.