fix(broadcast): normalize web3.js polling-fallback rejection

[rz1989s]

Summary

Diagnostic log from PR #303 revealed the real root cause of the prod 500 INTERNAL fallthrough that PR #302 was supposed to convert into 502 TX_FAILED_ON_CHAIN.

[tx/broadcast] caught error: {
  isError: false,
  isTFOCE: false,
  constructorName: 'Object',
  name: undefined,
  message: undefined,
  stringified: '[object Object]'
}

The thrown value is a plain Object, not a TransactionFailedOnChainError or any Error subclass — so every instanceof check in the route fails and we fall through to 500 INTERNAL "unknown error".

Root cause

In @solana/web3.js v1.98 (Connection#getTransactionConfirmationPromise), two paths can settle the confirmation:

1. WS-subscription path (onSignature callback) resolves the promise with { __type: PROCESSED, response: { context, value: { err } } }, so confirmTransaction resolves with { value: { err } } and PR fix(broadcast): bail on confirmed-with-err to avoid CF 504 #302's result.value.err check fires correctly.
2. getSignatureStatus polling fallback (~line 6601 of node_modules/@solana/web3.js/lib/index.cjs.js) calls reject(value.err) — it rejects with the bare TransactionError object (e.g. { InstructionError: [0, { Custom: 3012 }] }), not a thrown Error.

When the polling fallback wins the race (slow WS subscription on Helius devnet), confirmTransaction throws the bare plain object. PR #302 only handled the resolve path. Hence: 500 INTERNAL.

Fix

Wrap confirmTransaction in confirmInspected with a try/catch that normalizes any non-Error object rejection into a proper TransactionFailedOnChainError(signature, err). Real Error subclasses (TransactionExpiredBlockheightExceededError, SendTransactionError) propagate unchanged.

const confirmInspected = async (): Promise<string> => {
  let result
  try {
    result = await connection.confirmTransaction(...)
  } catch (err) {
    if (err !== null && typeof err === 'object' && !(err instanceof Error)) {
      throw new TransactionFailedOnChainError(signature, err)
    }
    throw err
  }
  if (result?.value?.err) {
    throw new TransactionFailedOnChainError(signature, result.value.err)
  }
  return signature
}

Also removes the diagnostic console.error from #303 (it served its purpose).

Test plan

• pnpm typecheck clean across root + sdk + app + agent
• pnpm vitest run tests/lib/sendWithRetry.test.ts tests/routes/tx-broadcast.test.ts — 23 passed (10 + 13)
• Local diag2 against live devnet confirms TransactionFailedOnChainError is thrown correctly via the resolve path
• Post-merge: re-run smoke against prod, expect 502 TX_FAILED_ON_CHAIN envelope

New tests

• normalizes polling-fallback rejection (bare TransactionError) into TransactionFailedOnChainError — mocks confirmTransaction to Promise.reject(programErr) and asserts outer rejection is the wrapped class with matching signature/err.
• preserves non-object rejection types (e.g. TransactionExpiredBlockheightExceededError) unchanged — guards against the normalization accidentally swallowing real Error instances.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
sipher	Ready	Preview, Comment	May 23, 2026 3:29pm