Skip to content

Clarify pseudocode for lift_x()#47

Closed
jnewbery wants to merge 2 commits intosipa:bip-schnorrfrom
jnewbery:2019-05-bip-schnorr-define-lift-x-c
Closed

Clarify pseudocode for lift_x()#47
jnewbery wants to merge 2 commits intosipa:bip-schnorrfrom
jnewbery:2019-05-bip-schnorr-define-lift-x-c

Conversation

@jnewbery
Copy link
Copy Markdown

  • define c
  • return x as the x-co-ordinate, not the undefined r
  • explicitly state that the return object is a point (and not eg an array or tuple of ints)

@sipa - I'm not sure what you prefer as developer workflow here. Do you want PRs against sipa/bip-schnorr or somewhere else? The force-push a few days ago has invalidated a bunch of the open PRs.

@sipa
Copy link
Copy Markdown
Owner

sipa commented May 18, 2019

@jnewbery PRs here are fine. I won't force push anymore.

@sipa
Copy link
Copy Markdown
Owner

sipa commented Aug 21, 2019

ACK, but needs rebase.

This was referenced Aug 21, 2019
@sipa
Copy link
Copy Markdown
Owner

sipa commented Aug 21, 2019

Closing in favor of rebase in #58.

@sipa sipa closed this Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants