Use key path spend terminology more consistently in taproot/tapscript#56
Merged
sipa merged 1 commit intosipa:bip-schnorrfrom Aug 22, 2019
jonasnick:keypath
Merged
Use key path spend terminology more consistently in taproot/tapscript#56sipa merged 1 commit intosipa:bip-schnorrfrom jonasnick:keypath
sipa merged 1 commit intosipa:bip-schnorrfrom
jonasnick:keypath
Conversation
sipa
reviewed
Aug 20, 2019
| The rules below only apply when validating a transaction input for which all of the conditions below are true: | ||
| * The transaction output is a '''segregated witness spend''' (i.e., either the scriptPubKey or BIP16 redeemScript is a witness program as defined in BIP141). | ||
| * It is a '''taproot spend''' as defined in bip-taproot (i.e., the witness version is 1, the witness program is 33 bytes, and the first of those is 0x00 or 0x01). | ||
| * It is a '''key path spend''' as defined in bip-taproot (i.e., the witness version is 1, the witness program is 33 bytes, and the first of those is 0x00 or 0x01). |
Owner
There was a problem hiding this comment.
This is not correct; it's about any kind of Taproot spend, not just key paths.
Owner
|
ACK apart from #56 (comment) |
Owner
|
Needs rebase. |
Author
|
rebased |
Author
|
rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sign_internal_keyis a always a bit confusing because you actually sign for the output key (but you're using the internal privkey).