Accept seckey in the form of bytes and not int in the reference BIP-schnorr code...#80
Merged
sipa merged 1 commit intosipa:bip-schnorrfrom Oct 7, 2019
jonasnick:bytes
Merged
Accept seckey in the form of bytes and not int in the reference BIP-schnorr code...#80sipa merged 1 commit intosipa:bip-schnorrfrom jonasnick:bytes
sipa merged 1 commit intosipa:bip-schnorrfrom
jonasnick:bytes
Conversation
…chnorr code to match the spec.
| def schnorr_sign(msg, seckey0): | ||
| if len(msg) != 32: | ||
| raise ValueError('The message must be a 32-byte array.') | ||
| seckey0 = int_from_bytes(seckey0) |
There was a problem hiding this comment.
Maybe rename to d as in the pseudocode? Then we don't need to overwrite the variable and its more consistent with the text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…to match the spec.