Conversation
Allows for PE classes in different quarters to have the same class number (which avoids the clobbering that was observed).
Keep the id field as the internal unique ID for an activity, while making a new field shortName for the name to be displayed in the schedule. This means that the "Q3." or "Q4." prefix is no longer displayed as such in the calendar (avoiding some confusion and keeping the separation between the internal and external IDs); we can figure out a way later for displaying the quarter number cleanly.
psvenk
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some new fields are in the CSV they gave us, and we have to account for a PE class having the same number in multiple different quarters (not sure if this is already handled, but we should check before merging).