Add support for half-credit HASS-A classes#339
Open
hanahmed05 wants to merge 3 commits into
Open
Conversation
Collaborator
|
Would it be possible to generalize this a bit? eg rather than having |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for distinguishing half-credit HASS-A classes in Hydrant. Previously, these classes were displayed identically to full-credit HASS-A classes, which could mislead users when planning their schedules.
Changes
is_half_classfield to the RawClass TypeScript interfaceis_half_classpackage.py) to mark all 21M.1* and 21M.4* classes as half-creditTesting
python scrapers/package.pyis_half_classappears inpublic/latest.jsonnpm run dev) and confirmed: