Skip to content

Allow Debian packaging using builder's native architecture#288

Merged
adubovikov merged 3 commits intosipcapture:masterfrom
jwarnier:allow_debian_pkg_native_architecture
Feb 4, 2026
Merged

Allow Debian packaging using builder's native architecture#288
adubovikov merged 3 commits intosipcapture:masterfrom
jwarnier:allow_debian_pkg_native_architecture

Conversation

@jwarnier
Copy link
Copy Markdown
Contributor

@jwarnier jwarnier commented Jan 30, 2026

Allow building the Debian packages for the builder's architecture (i.e. 'amd64' no longer hardcoded).
Works on ARM64.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 30, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jwarnier
❌ adubovikov
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Debian 10 and 11 builder scripts so that Debian packages are built for the builder’s native architecture instead of being hardcoded to amd64.

Changes:

  • Introduces an ARCH variable derived from dpkg --print-architecture and uses it in the generated .deb filename.
  • Updates dependency extraction to attempt to strip the architecture suffix dynamically instead of assuming :amd64.
  • Cleans up and corrects some apt-get install lines and comments in the builder scripts.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
pkg/debian/builder-debian11/builder.sh Uses the builder’s detected architecture for dependency normalization and output package naming; adjusts package installation commands.
pkg/debian/builder-debian10/builder.sh Mirrors the architecture-aware dependency handling and output naming for Debian 10, plus minor cleanup of install/comment lines.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/debian/builder-debian11/builder.sh Outdated
Comment thread pkg/debian/builder-debian10/builder.sh Outdated
@kYroL01
Copy link
Copy Markdown
Collaborator

kYroL01 commented Feb 2, 2026

Hello @jwarnier, Thanks for the PR. Please check the two Copilot suggestions.
Then we're ready to merge it.

adubovikov and others added 2 commits February 4, 2026 10:40
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@adubovikov adubovikov merged commit 04c526f into sipcapture:master Feb 4, 2026
1 check was pending
@jwarnier jwarnier deleted the allow_debian_pkg_native_architecture branch March 30, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants