refactor(card): migrate module css to vanilla extract by froggy1014 · Pull Request #148 · sipe-team/side

froggy1014 · 2025-04-20T14:36:41Z

Changes

Module CSS -> Vanilla Extract 마이그레이션
스토리북 개선

Visuals

Checklist

Have you written the functional specifications?
Have you written the test code?

Additional Discussion Points

changeset-bot · 2025-04-20T14:36:45Z

⚠️ No Changeset found

Latest commit: 0a4c323

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-04-20T14:36:47Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

noahluftyang · 2025-04-21T00:42:32Z

packages/card/src/Card.tsx

+export type CardRatio = keyof typeof styles.CardRatio;
+export type CardVariant = keyof typeof styles.CardVariant;


타입도 스타일에서 내보내거나 반대로 상수를 이 파일에서 정의하면 어떨까? 동일한 개념이 서로 다른 파일에서 관리되면 응집도가 떨어지게 되는 것 같아~

@noahluftyang

이런 multi-variants 같은 경우 recipe API를 사용해서 선언해도 괜찮을 것 같아서.. 이번 커밋에 적용해봤는데 어떻게 생각하세요? 가독성, 응집도면으로나 더 나은것 같구 추후 theme을 위해서 토큰 적용도 쉬울 것 같아요.

https://vanilla-extract.style/documentation/packages/recipes/

Reference

https://github.com/mirror-xyz/degen/blob/main/components/src/components/Spinner/styles.css.ts

recipe API는 좋은 것 같아~ 다만 기존에 외부로 export 해주던 CardRatio와 CardVariant가 사라지게 되면, 사용자에게는 Breaking Changes가 발생하게 될 것 같아 ㅎㅎ BC 없이 적용할 방법을 더 고려해보면 어떨까??

호고곡 그건 생각못해봤네요. 상수를 다시 선언해서 말씀해주신대로 interface로 바꿔보았어욤

noahluftyang · 2025-04-21T09:09:15Z

packages/card/src/Card.tsx

+export type CardProps = CardVariants &
+  ComponentProps<'div'> & {
+    asChild?: boolean;
+  };


Suggested change

export type CardProps = CardVariants &

ComponentProps<'div'> & {

asChild?: boolean;

};

export interface CardProps extends ComponentProps<'div'>, CardVariants {

asChild?: boolean;

};

우리 프로젝트에서 Props는 타입 보다는 인터페이스로 선언하는게 주된 흐름이라고 느끼는데, 특별한 이유가 있는게 아니라면 동일하게 유지해주는게 어떨까??

noahluftyang

gogo~

refactor(card): migrate module css to vanilla extract

098e437

froggy1014 requested review from SEMIN-97, bae-sh, developerjhp, heeji289, hy57in, jiji-hoon96, kimdaeyeob, noahluftyang, synuns and yeojini as code owners April 20, 2025 14:36

auto-assign bot assigned froggy1014 Apr 20, 2025

noahluftyang reviewed Apr 21, 2025

View reviewed changes

refactor(card): apply recipe API for multi-variants define

18f2502

noahluftyang reviewed Apr 21, 2025

View reviewed changes

froggy1014 added 2 commits April 22, 2025 03:06

refactor(card): redefine constants

05b60b3

chore(card): export Card.css alongside Card component

0a4c323

noahluftyang approved these changes Apr 22, 2025

View reviewed changes

froggy1014 merged commit 2785dee into release/v1 Apr 22, 2025
3 checks passed

froggy1014 deleted the refactor/card branch April 22, 2025 04:44

noahluftyang pushed a commit that referenced this pull request Apr 26, 2025

refactor(card): migrate module css to vanilla extract (#148)

1ccea10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(card): migrate module css to vanilla extract#148

refactor(card): migrate module css to vanilla extract#148
froggy1014 merged 4 commits intorelease/v1from
refactor/card

froggy1014 commented Apr 20, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Apr 20, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Apr 20, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

noahluftyang Apr 21, 2025

Uh oh!

froggy1014 Apr 21, 2025 •

edited

Loading

Uh oh!

noahluftyang Apr 21, 2025

Uh oh!

froggy1014 Apr 21, 2025

Uh oh!

noahluftyang Apr 21, 2025

Uh oh!

noahluftyang left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		export type CardRatio = keyof typeof styles.CardRatio;
		export type CardVariant = keyof typeof styles.CardVariant;

Conversation

froggy1014 commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Visuals

Checklist

Additional Discussion Points

Uh oh!

changeset-bot bot commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Apr 20, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

noahluftyang Apr 21, 2025

Choose a reason for hiding this comment

Uh oh!

froggy1014 Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

noahluftyang Apr 21, 2025

Choose a reason for hiding this comment

Uh oh!

froggy1014 Apr 21, 2025

Choose a reason for hiding this comment

Uh oh!

noahluftyang Apr 21, 2025

Choose a reason for hiding this comment

Uh oh!

noahluftyang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

froggy1014 commented Apr 20, 2025 •

edited

Loading

changeset-bot bot commented Apr 20, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

froggy1014 Apr 21, 2025 •

edited

Loading