refactor: use react catalog for efficient version management#175
refactor: use react catalog for efficient version management#175noahluftyang merged 1 commit intomainfrom
Conversation
|
✅ Deploy Preview for side-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughReact 및 관련 타입 패키지의 버전 관리를 중앙화하기 위해 pnpm-workspace.yaml에 Changes
Sequence Diagram(s)sequenceDiagram
participant 패키지 as 각 패키지(package.json)
participant 워크스페이스 as pnpm-workspace.yaml
패키지->>워크스페이스: "catalog:react" 의존성 요청
워크스페이스-->>패키지: catalogs.react에서 버전 정보 제공
패키지->>패키지: React 및 타입 패키지 버전 통일 적용
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (19)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (60)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 🚀 New features to boost your workflow:
|
froggy1014
left a comment
There was a problem hiding this comment.
release/v1 쪽에 머지하는게 낫지않을까요 ?
conflict 잡을때 뭔가 힘들거 같다는 생각이 드네요 ㅎㅎㅎ...
synuns
left a comment
There was a problem hiding this comment.
catalog로 리액트 버전 통일하는게 일관성게 관리할 수 있어서 좋을 것 같네요~
* feat(accordion): scaffold Accordion component setup * feat(accordion): add test scenario for Accordion component * feat(accordion): add sanitize.css for improved styling consistency * chore(accordion): add typography dependency for consistent styling * feat(accordion): implement Accordion component * feat(accordion): add Accordion stories for component documentation * refactor(accordion): decouple AccordionItemContext for reusability * refactor(accordion): add hook for accordion animations * feat(accordion): implement accordion animation using custom hook * refactor(accordion): simplifies Accordion stories Updates the Accordion story to use the `` component directly and removes unnecessary props from `Accordion.Root` for simpler and more focused examples. * test(accordion): adds Accordion component tests Adds comprehensive tests for the Accordion component, covering: - Root style defaults (border-radius, border, background-color, padding) - Trigger style defaults (text alignment, aria-expanded, icon presence) - Content style defaults (border-radius, background-color, padding) - Toggle functionality - Correct rendering of children elements * docs(accordion): adds Accordion component documentation Creates a README file to document the Accordion component. This includes installation instructions, usage examples, features overview, component details (Root, Item, Trigger, Content), styling information, and preview instructions using Storybook. * chore: annotate token package as workspace * chore: apply format on biome.json * chore(accordiong): remove unused CSS module declaration * chore(accordion): moves interface to component file * refactor: use react catalog for efficient version management (#175) * fix(grid): specifies ref type for grid * fix(flex): improve type definitions for flex * chore(flex): remove duplicate files entry * chore(accordion): remove duplicate files entry * chore(input): removes unused prop * fix(skeleton): specifies ref type for skeleton * fix(pnpm-lock): update dependencies to latest versions * chore(accordion): translate error message from korean to english * refactor(accordion): provide default value fro AccordionItemContext * refactor(accordion): moves typography to devDependencies * refactor(accordion): add indicator and refactor Accordion components * test(accordion): add indicator test for accordion icon rendering * feat(accordion): adds Accordion.Indicator and asChild prop story --------- Co-authored-by: Jeongmin Lee <clcl6084@gmail.com> Co-authored-by: y09n <euihyun.yang.9x@gmail.com>
Changes
Visuals
Checklist
Additional Discussion Points
Summary by CodeRabbit